Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new version 4 configuration for Djibouti OND forecasts and updates the default predictor to use this new version. The changes introduce a new forecast dataset configuration with updated paths and settings while maintaining consistency with the existing configuration structure.
Changes:
- Updated default predictor from
pnep-v2toprcp-v4 - Added new
prcp-v4forecast configuration with pathdjibouti/prcp-ond-v4.zarr
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pct: quantile | ||
| colormap: pne_25 | ||
| is_poe: no | ||
| prcp-v4: |
There was a problem hiding this comment.
The key naming is inconsistent with existing entries. The previous entries use pnep-2023 and pnep-v2, but the new entry uses prcp-v4. For consistency within the Djibouti OND configuration, consider using pnep-v4 or updating all entries to use the prcp- prefix consistently.
| prcp-v4: | |
| pnep-v4: |
| @@ -5130,6 +5130,19 @@ countries: | |||
| pct: quantile | |||
| colormap: pne_25 | |||
| is_poe: no | |||
There was a problem hiding this comment.
The version numbering skips from v2 to v4, which may cause confusion. Consider clarifying why v3 was skipped, or if v3 exists elsewhere, ensure consistency in the versioning scheme.
| is_poe: no | |
| is_poe: no | |
| # Note: Version 3 was an internal experimental configuration and is not exposed in this file; the next public release is v4. |
|
@nitinmagima please turn off the copilot automatic reviews of your PRs. Nobody else's PRs do this. |
2 participants
Added Djibouti OND v4.